Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: serde transactions #943

Conversation

AvivYossef-starkware
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware commented Sep 23, 2024

build: regression test crate

build: blockifier regression test add block info

build: blockifier regression test add get fee token addresses

build: serde transactions

NO


This change is Reviewable

Copy link
Contributor Author

AvivYossef-starkware commented Sep 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on Graphite Graphite

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [67.218 ms 67.284 ms 67.366 ms]
change: [-7.8697% -4.5611% -1.7381%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.78%. Comparing base (f5fbf0a) to head (2fdcd8d).

Files with missing lines Patch % Lines
crates/blockifier/src/transaction/transactions.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           aviv/test_regression_test_utils     #943       +/-   ##
====================================================================
+ Coverage                            62.30%   75.78%   +13.48%     
====================================================================
  Files                                  127       87       -40     
  Lines                                12974    11090     -1884     
  Branches                             12974    11090     -1884     
====================================================================
+ Hits                                  8083     8405      +322     
+ Misses                                4474     2273     -2201     
+ Partials                               417      412        -5     
Flag Coverage Δ
75.78% <33.33%> (+13.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware changed the title build: regression test crate build: serde transactions Sep 23, 2024
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.632 ms 66.757 ms 66.905 ms]
change: [-8.0606% -4.7646% -1.8747%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant